This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
test: mark test-net-error-twice flaky on SmartOS #25760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that test-net-error-twice.js does not behave as expected. Its goal is to test fireErrorCallbacks, but it doesn't do it correctly, leading to false negatives on some platforms and failures on others. This change marks this test as flaky so that we can use our CI to land changes in the v0.10 branch until we can fix it properly. See the corresponding issue at nodejs#9325 for more details.
|
/cc @joyent/node-collaborators |
|
LGTM |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jul 23, 2015
It seems that test-net-error-twice.js does not behave as expected. Its goal is to test fireErrorCallbacks, but it doesn't do it correctly, leading to false negatives on some platforms and failures on others. This change marks this test as flaky so that we can use our CI to land changes in the v0.10 branch until we can fix it properly. See the corresponding issue at nodejs#9325 for more details. PR: nodejs#25760 PR-URL: nodejs#25760 Reviewed-By: João Reis <[email protected]>
|
Landed in 7df5770, thank you @joaocgreis! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that test-net-error-twice.js does not behave as expected. Its
goal is to test fireErrorCallbacks, but it doesn't do it correctly,
leading to false negatives on some platforms and failures on others.
This change marks this test as flaky so that we can use our CI to land
changes in the v0.10 branch until we can fix it properly.
See the corresponding issue at
#9325 for more details.